Skip to content

Commit

Permalink
Delete Storybook stories that use randomly generated data (#1594)
Browse files Browse the repository at this point in the history
These aren't particularly useful - the widgets they generate often look broken,
and it's hard to tell if there's a bug in the widget or the input data is just
something a human would never create.

I believe this completes the effort (started by @handeyeco) to move code out of
`perseus/src/widgets` and into specific widget subdirectories.

Issue: none

## Test plan:

`yarn test`

Author: benchristel

Reviewers: handeyeco, jeremywiebe

Required Reviewers:

Approved By: handeyeco

Checks: ❌ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald

Pull Request URL: #1594
  • Loading branch information
benchristel authored Sep 5, 2024
1 parent d88b0ff commit 435f3f6
Show file tree
Hide file tree
Showing 10 changed files with 7 additions and 700 deletions.
7 changes: 7 additions & 0 deletions .changeset/proud-goats-provide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@khanacademy/perseus-dev-ui": patch
"@khanacademy/perseus": patch
"@khanacademy/perseus-editor": patch
---

Internal: Remove Storybook stories that generate random widgets

This file was deleted.

This file was deleted.

53 changes: 0 additions & 53 deletions packages/perseus/src/widgets/__testdata__/randomizers.test.ts

This file was deleted.

Loading

0 comments on commit 435f3f6

Please sign in to comment.