tweak comments

Khan · Sep 24, 2024 · 2437282 · 2437282
1 parent 4fd4235
commit 2437282
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/packages/perseus/src/widgets/radio/radio-component.tsx b/packages/perseus/src/widgets/radio/radio-component.tsx
@@ -35,8 +35,10 @@ export type RenderProps = {
 };
 
 export type UserInput = {
-    countChoices?: boolean;
     choicesSelected: ReadonlyArray<boolean>;
+    // I wonder if UserInput should only be `choicesSelected`
+    // and everything else should just be on the rubric
+    countChoices?: boolean;
     numCorrect?: number;
     noneOfTheAboveIndex?: number | null | undefined;
     noneOfTheAboveSelected?: boolean;

diff --git a/packages/perseus/src/widgets/radio/radio-validator.test.ts b/packages/perseus/src/widgets/radio/radio-validator.test.ts
@@ -24,9 +24,6 @@ describe("radioValidator", () => {
 
     it("is invalid when number selected does not match number correct", () => {
         const userInput = {
-            // TODO: I don't think user input should have numCorrect
-            // (it should likely be looking for that on the rubric)
-            // but I'm testing the logic that currently exists
             numCorrect: 2,
             choicesSelected: [true, false, false, false],
         };
@@ -47,9 +44,6 @@ describe("radioValidator", () => {
 
     it("is invalid when none of the above and an answer are both selected", () => {
         const userInput = {
-            // TODO: I don't think user input should have noneOfTheAboveSelected
-            // (it should likely be looking for noneOfTheAboveIndex on the rubric)
-            // but I'm testing the logic that currently exists
             noneOfTheAboveSelected: true,
             choicesSelected: [true, false, false, false, true],
         };