Skip to content
Node CI

Fix: Image widget editor fails to calculate image dimensions #2270

Sign in to view logs

Fix: Image widget editor fails to calculate image dimensions

Fix: Image widget editor fails to calculate image dimensions #2270

Triggered via pull request July 26, 2023 21:15
@nixterrimusnixterrimus
synchronize #618
new/image-size-loading
Status Failure
Total duration 11m 38s
Artifacts –

node-ci.yml

on: pull_request
Matrix: Jest Coverage
Matrix: Cypress Coverage
Matrix: Check for .changeset file
Matrix: Check builds for changes in size
Matrix: Extract i18n strings
Matrix: Lint, Typecheck, and Test
Matrix: Publish npm snapshot
finish_coverage
3s
finish_coverage
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 5 warnings
Check for .changeset file (ubuntu-latest, 16.x)
This PR does not have a changeset. You can add one by running `yarn changeset` and following the prompts. If this PR doesn't need a changeset, run `yarn changeset --empty` and commit results.
Lint, Typecheck, and Test (ubuntu-latest, 16.x): packages/perseus-editor/src/widgets/image-editor.tsx#L14
There should be at least one empty line between import groups
Lint, Typecheck, and Test (ubuntu-latest, 16.x): packages/perseus-editor/src/widgets/image-editor.tsx#L15
`util/types` import should occur before import of `@khanacademy/perseus`
Lint, Typecheck, and Test (ubuntu-latest, 16.x): packages/perseus-editor/src/widgets/image-editor.tsx#L15
'isBooleanObject' is defined but never used. Allowed unused vars must match /^_*$/u
Lint, Typecheck, and Test (ubuntu-latest, 16.x): packages/perseus-editor/src/widgets/image-editor.tsx#L104
img elements must have an alt prop, either with meaningful text, or an empty string for decorative images
Lint, Typecheck, and Test (ubuntu-latest, 16.x): packages/perseus/src/util.ts#L842
'image' is never reassigned. Use 'const' instead
Lint, Typecheck, and Test (ubuntu-latest, 16.x): packages/perseus/src/util.ts#L848
Insert `;`
Lint, Typecheck, and Test (ubuntu-latest, 16.x): packages/perseus/src/util.ts#L848
Missing semicolon
Lint, Typecheck, and Test (ubuntu-latest, 16.x): packages/perseus/src/util.ts#L855
Delete `··`
Lint, Typecheck, and Test (ubuntu-latest, 16.x)
Error: Command failed: yarn lint "packages/perseus-editor/src/widgets/image-editor.tsx" "packages/perseus/src/util.ts"
Extract i18n strings (ubuntu-latest, 16.x)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Cypress Coverage (ubuntu-latest, 16.x)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Check builds for changes in size (ubuntu-latest, 16.x)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, preactjs/compressed-size-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Jest Coverage (ubuntu-latest, 16.x)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Lint, Typecheck, and Test (ubuntu-latest, 16.x)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/