-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't fail out if the python docstring on the first line of a file is…
… too long Summary: See https://app.asana.com/0/27216215224639/40389455104495 Test Plan: In webapp: python -c "print '\"\"\"' + '.' * 80 + '\"\"\"\n'" > foo.py ~/khan/devtools/khan-linter/runlint.py foo.py And see that it outputs this: foo.py:1:80: E501 line too long (86 characters) Instead of this: local variable 'linenum' referenced before assignment Reviewers: csilvers Reviewed By: csilvers Subscribers: colin Differential Revision: https://phabricator.khanacademy.org/D19293
- Loading branch information
Showing
3 changed files
with
18 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"project_id": "khan-linter", | ||
"conduit_uri": "https://phabricator.khanacademy.org/", | ||
"lint.engine": "ArcanistConfigurationDrivenLintEngine" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"linters": { | ||
"khan-linter": { | ||
"type": "script-and-regex", | ||
"script-and-regex.script": "~\/khan\/devtools\/khan-linter\/runlint.py --always-exit-0 --blacklist=yes --propose-arc-fixes", | ||
"script-and-regex.regex": "\/^((?P<file>[^:]*):(?P<line>\\d+):((?P<char>\\d+):)? (?P<name>((?P<error>E)|(?P<warning>W))\\S+) (?P<message>[^\\x00]*)(\\x00(?P<original>[^\\x00]*)\\x00(?P<replacement>[^\\x00]*)\\x00)?)|(?P<ignore>SKIPPING.*)$\/m" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters