Skip to content

Commit

Permalink
Roll back Khan Exercises and add warnings.
Browse files Browse the repository at this point in the history
Summary:
In January, some changes were made to Khan Exercises that breaks
an assumption that graphie-to-png makes. Namely that graphie will
always render everything into a single SVG.

This caused a regression that affected a number of content creators.
See https://app.asana.com/0/27216215224639/36842953088193 for the
support ticket.

This change brings us back to stable behavior in gaphie-to-png. But
now we're stuck. If we ever want to upgrade graphie-to-png to be up
to date with Khan Exercises again, we need to do a bunch of work. I've
added some warnings about this in the README that will hopefully
prevent us from upgrading Khan Exercises without considering this.

I've cherry picked in the color changes into a new graphie-to-png
branch of Khan Exercises to prevent regressions from that.

Test Plan:
A.1) Serve graphie-to-png locally
A.2) Go to http://localhost:5001/#27
A.3) See beautiful graph, and no errors

B.1) Serve graphie-to-png locally
B.2) Go to http://localhost:5001/#1
B.3) Change all references to `BLUE` to `GOLD_C`
B.4) Regraph
B.5) See the line turn gold

I cannot get "Convert to Image" to work locally, despite my best
efforts. I have confirmed that everything is being rendered into a
single SVG, which gives me high confidence. I will also test once this
is deployed to AWS (and rolling back is trivial), so I think this is
sufficient.

Reviewers: aria, emily

Reviewed By: emily

Differential Revision: https://phabricator.khanacademy.org/D18542
  • Loading branch information
itsjohncs committed Jun 11, 2015
1 parent 98692c3 commit 07609da
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

A tool for converting graphie JS code to a png image, available at http://graphie-to-png.khanacademy.org/.

## Warning to Devs

Khan Exercises is very out of date. This is because graphie-to-png will not work after some changes made in January, 2015. See [this support ticket](https://app.asana.com/0/27216215224639/36842953088193) for more information.

Upgrading Khan Exercises would be a fairly large task, so you may want to consider other alternatives instead (like cherry picking into the `graphie-to-png` branch of Khan Exercises).

## Local server

To run this locally, fill in `secrets.py` using the template at `secrets.py.example` then run `python app.py`.
Expand Down
2 changes: 1 addition & 1 deletion khan-exercises
Submodule khan-exercises updated 71 files
+1 −2 .arcconfig
+0 −9 .arclint
+6 −0 Gemfile
+2 −4 Makefile
+0 −233 build/pack.js
+242 −0 build/pack.rb
+2 −20 css/khan-exercise.css
+1 −1 exercises/absolute_value_equations.html
+1 −1 exercises/age_word_problems.html
+6 −6 exercises/angle_bisector_theorem.html
+1 −3 exercises/angles_2.html
+6 −17 exercises/angles_of_a_polygon.html
+162 −120 exercises/balancing_chemical_equations.html
+4 −4 exercises/comparing_fractions_1.html
+2 −1 exercises/dice_probability.html
+2 −3 exercises/divisibility_intuition.html
+4 −2 exercises/equation_of_a_hyperbola.html
+1 −1 exercises/extraneous_solutions.html
+1 −1 exercises/factoring_linear_binomials.html
+6 −16 exercises/fractions_cut_and_copy_1.html
+4 −13 exercises/fractions_cut_and_copy_2.html
+15 −21 exercises/graphing_inequalities.html
+19 −38 exercises/graphing_inequalities_2.html
+19 −30 exercises/graphing_systems_of_equations.html
+32 −42 exercises/graphing_systems_of_inequalities.html
+34 −58 exercises/graphing_systems_of_inequalities_2.html
+2 −2 exercises/graphs_of_sine_and_cosine.html
+3 −3 exercises/khan-exercise.html
+2 −2 exercises/multiplying_and_dividing_complex_number_polar_forms.html
+9 −11 exercises/multiplying_and_dividing_negative_numbers.html
+61 −84 exercises/multiplying_and_dividing_scientific_notation.html
+2 −2 exercises/multistep_equations_with_distribution.html
+3 −3 exercises/number_line_3.html
+1 −1 exercises/one_step_equation_intuition.html
+12 −7 exercises/ordering_decimals.html
+0 −4 exercises/ordering_fractions.html
+0 −4 exercises/ordering_negative_numbers.html
+9 −7 exercises/parabola_intuition_2.html
+4 −2 exercises/parabola_intuition_3.html
+4 −4 exercises/perimeter_1.html
+3 −9 exercises/plotting_the_line_of_best_fit.html
+3 −3 exercises/point_slope_form.html
+1 −1 exercises/positive_and_zero_exponents.html
+0 −4 exercises/scientific_notation_intuition.html
+4 −4 exercises/solving_quadratics_by_factoring.html
+2 −2 exercises/solving_quadratics_by_factoring_2.html
+3 −3 exercises/solving_quadratics_by_taking_the_square_root.html
+1 −5 exercises/views_of_a_function.html
+96 −151 interface.js
+9 −49 khan-exercise.js
+29 −22 local-only/katex/katex.css
+1,340 −3,524 local-only/katex/katex.js
+1 −2 local-only/main.js
+0 −1,400 local-only/moment.js
+0 −1 local-only/update_local.sh
+1 −4 package.json
+0 −1 utils/algebra-intuition.js
+2 −5 utils/answer-types.js
+4 −4 utils/congruency.js
+23 −29 utils/constructions.js
+0 −4 utils/graphie-drawing.js
+1 −1 utils/graphie.js
+116 −208 utils/interactive.js
+1 −1 utils/math-format.js
+0 −75 utils/objective_.js
+0 −4 utils/subhints.js
+0 −60 utils/transform-helpers.js
+0 −79 utils/wrapped-defaults.js
+0 −73 utils/wrapped-ellipse.js
+0 −84 utils/wrapped-line.js
+0 −39 utils/wrapped-path.js

0 comments on commit 07609da

Please sign in to comment.