New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: return zero value in getter methods if receiver is nil #359

Open

WingT wants to merge 1 commit into Khan:main from WingT:main

WingT commented Oct 21, 2024

Add nil check in go structs' getter methods, making chained function call like a.GetB().GetC().GetD() won't panic.

I have:

Written a clear PR title and description (above)
Signed the Khan Academy CLA
Added tests covering my changes, if applicable
Included a link to the issue fixed, if applicable
Included documentation, for new features
Added an entry to the changelog


          feat: return zero value in getter methods if receiver is nil

e544091

Change-Id: If1c1c5f305cae0abda2f80b8c3e3c1ec37a3d8dc

WingT requested review from benjaminjkraft, csilvers, dnerdy and StevenACoffman as code owners

October 21, 2024 08:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjaminjkraft Awaiting requested review from benjaminjkraft benjaminjkraft is a code owner

csilvers Awaiting requested review from csilvers csilvers is a code owner

dnerdy Awaiting requested review from dnerdy dnerdy is a code owner

StevenACoffman Awaiting requested review from StevenACoffman StevenACoffman is a code owner

Labels

None yet