Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: always set omitempty on pointer fields #287

Closed
wants to merge 2 commits into from
Closed

feat: always set omitempty on pointer fields #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83dcc0b
feat: always set omitempty on pointer fields
obitech Jul 27, 2023
ad604f4
feat: extend changelog
obitech Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ When releasing a new version:
### Bug fixes:
- Using `pointer: true` will generate `omitempty` tags to all pointer input types.
-->

## next
Expand Down
9 changes: 8 additions & 1 deletion generate/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,13 +450,20 @@ func (g *generator) convertDefinition(
return nil, err
}

// We always want to set omitempty if the field is a pointer, unless
// the user explicitly wants the value to be sent as null.
omitEmpty := fieldOptions.GetOmitempty()
if options.GetPointer() || (!field.Type.NonNull && g.Config.Optional == "pointer") && fieldOptions.Omitempty == nil {
omitEmpty = true
}

goType.Fields[i] = &goStructField{
GoName: goName,
GoType: fieldGoType,
JSONName: field.Name,
GraphQLName: field.Name,
Description: field.Description,
Omitempty: fieldOptions.GetOmitempty(),
Omitempty: omitEmpty,
}
}
return goType, nil
Expand Down
Loading