Add ability to ask user to confirm widget creation when not supported by current language #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, this returns all languages. Generators can override this to limit which languages are supported. Popup windows are the initial test case since Perl and XRC are not supported.
Return a std::pair makes it possible to return an error code if the node could not be created. Adding verify_language_support results in verifying with the generator that the language supports the widget being created.
Handles the new std::pair return and the optional verify_language_support parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
NodeCreator::createNodeandNode::createChildNodeso that they take averify_language_supportparameter and return astd::pair<NodeSharedPtr, int>containing the node and an error code. In addition, generators can now override a newSupportedLanguages()method which allows each generator to specify which languages the generator supports. Combining the two changes makes it possible to notify the user that a requested widget is not supported in the project'scode_preferencesetting. The user then has the option of creating the node anyway, or cancelling creation of the widget.See #1509