feat: Add Flysystem v2 and v3 compatibility #199
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the library to be compatible with both Flysystem v2 and v3.
Key changes include:
- Updated `composer.json` to allow `league/flysystem` versions `^2.5 || ^3.0`.
- Modified `src/Storage/FlysystemStorage.php` to correctly handle exceptions and return values from Flysystem v2/v3 methods:
- `fetch()` now catches `FilesystemException` during read and returns `null`.
- `save()` ensures `true` is returned on success and `false` on `FilesystemException`.
- `delete()` now correctly returns `false` if a `FilesystemException` occurs (previously returned `true`).
- Added `tests/Storage/FlysystemStorageTest.php` with new unit tests covering success and failure scenarios for `fetch`, `save`, and `delete` operations, including mocking Flysystem exceptions. This ensures the storage layer behaves as expected when underlying file operations fail.
- Added `phpspec/prophecy-phpunit` to dev dependencies for mocking in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the library to be compatible with both Flysystem v2 and v3.
Key changes include:
composer.jsonto allowleague/flysystemversions^2.5 || ^3.0.src/Storage/FlysystemStorage.phpto correctly handle exceptions and return values from Flysystem v2/v3 methods:fetch()now catchesFilesystemExceptionduring read and returnsnull.save()ensurestrueis returned on success andfalseonFilesystemException.delete()now correctly returnsfalseif aFilesystemExceptionoccurs (previously returnedtrue).tests/Storage/FlysystemStorageTest.phpwith new unit tests covering success and failure scenarios forfetch,save, anddeleteoperations, including mocking Flysystem exceptions. This ensures the storage layer behaves as expected when underlying file operations fail.phpspec/prophecy-phpunitto dev dependencies for mocking in tests.