Issue checkstyle#11446: Update Filesetchecktest to use verifyWithInli…

…neConfigParser
Kevin222004 · Dec 10, 2023 · 0946950 · 0946950
1 parent ac6d6f0
commit 0946950
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/pom.xml b/pom.xml
@@ -1824,7 +1824,6 @@
                 <exclude>**/RegexpHeaderCheckTest.class</exclude>
 
                 <!-- all bellow until https://github.com/checkstyle/checkstyle/issues/11446 -->
-                <exclude>**/FileSetCheckTest.class</exclude>
                 <exclude>**/AbstractFileSetCheckTest.class</exclude>
                 <exclude>**/DetailAstImplTest.class</exclude>
                 <exclude>**/TreeWalkerTest.class</exclude>

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/FileSetCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/FileSetCheckTest.java
@@ -38,10 +38,8 @@ protected String getPackageLocation() {
 
     @Test
     public void testTranslation() throws Exception {
-        final Configuration checkConfig =
-            createModuleConfig(TestFileSetCheck.class);
         final String[] expected = CommonUtil.EMPTY_STRING_ARRAY;
-        verify(checkConfig, getPath("InputFileSetIllegalTokens.java"), expected);
+        verifyWithInlineConfigParser(getPath("InputFileSetIllegalTokens.java"), expected);
 
         assertWithMessage("destroy() not called by Checker")
                 .that(TestFileSetCheck.isDestroyed())
@@ -50,11 +48,8 @@ public void testTranslation() throws Exception {
 
     @Test
     public void testProcessCallsFinishBeforeCallingDestroy() throws Exception {
-        final Configuration checkConfig =
-            createModuleConfig(TestFileSetCheck.class);
         final String[] expected = CommonUtil.EMPTY_STRING_ARRAY;
-
-        verify(checkConfig, getPath("InputFileSetIllegalTokens.java"), expected);
+        verifyWithInlineConfigParser(getPath("InputFileSetIllegalTokens.java"), expected);
 
         assertWithMessage("FileContent should be available during finishProcessing() call")
                 .that(TestFileSetCheck.isFileContentAvailable())

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/bdd/TestInputConfiguration.java b/src/test/java/com/puppycrawl/tools/checkstyle/bdd/TestInputConfiguration.java
@@ -55,7 +55,8 @@ public final class TestInputConfiguration {
             "com.puppycrawl.tools.checkstyle.checks.sizes.FileLengthCheck",
             "com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck",
             "com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck",
-            "com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheckTest$ViolationFileSetCheck"
+            "com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheckTest$ViolationFileSetCheck",
+            "com.puppycrawl.tools.checkstyle.api.FileSetCheckTest$TestFileSetCheck"
     ));
 
     private final List<ModuleInputConfiguration> childrenModules;

diff --git a/...test/resources/com/puppycrawl/tools/checkstyle/api/fileset/InputFileSetIllegalTokens.java b/...test/resources/com/puppycrawl/tools/checkstyle/api/fileset/InputFileSetIllegalTokens.java
@@ -1,3 +1,8 @@
+/*
+com.puppycrawl.tools.checkstyle.api.FileSetCheckTest$TestFileSetCheck
+
+*/
+
 package com.puppycrawl.tools.checkstyle.api.fileset;
 
 public class InputFileSetIllegalTokens