String cleanups #330
Merged
String cleanups #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The memory behind the source pointer passed to memcpy() is only read, make the function prototype match that fact. This allows us to get rid of some casts. Signed-off-by: Mathias Krause <[email protected]>
Make strdup("") do the right thing -- return a duplicate of an empty
string, not NULL. Only return NULL if we got passed a NULL pointer or
the memory allocation failed.
Signed-off-by: Mathias Krause <[email protected]>
Tweak the implementation of strdup() by making ues of memcpy() for the actual string copy, as we already determined its length before. Signed-off-by: Mathias Krause <[email protected]>
Instead of attaching the __noreturn annotation to the definition, attach it to the declaration of panic() to make callers aware that this function won't return. Signed-off-by: Mathias Krause <[email protected]>
Move the duplicated code of panic() and warning() to a common helper
that'll take care about the printk()s. The message type ("PANIC" /
"WARNING") will still be center aligned.
Signed-off-by: Mathias Krause <[email protected]>
sktt
approved these changes
Nov 13, 2023
wipawel
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanups I noticed while reviewing some PRs last week.