Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pmm: properly detect first available memory region #281

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

wipawel
Copy link
Contributor

@wipawel wipawel commented Aug 21, 2023

For the first available usable region we need a space of at least EARLY_VIRT_MEM MB, which is not below first MB.
Since some UEFI firmware allocates more than one usable region below the first MB with size of 4096 bytes, it is better to dynamically scan all usable regions and select the first one matching above criteria.

For the first available usable region we need a space of at least
EARLY_VIRT_MEM MB, which is not below first MB.
Since some UEFI firmware allocates more than one usable region
below the first MB with size of 4096 bytes, it is better to
dynamically scan all usable regions and select the first one
matching above criteria.

Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
@wipawel wipawel added the bugfix This fixes a bug label Aug 21, 2023
@wipawel wipawel requested a review from a team as a code owner August 21, 2023 09:41
@wipawel wipawel enabled auto-merge (rebase) August 21, 2023 09:41
@sirdarckcat
Copy link

Thanks!!

Tested on a Thinkstation P360 Tower (1S)MT that had the affected issue and it works!

@wipawel wipawel disabled auto-merge August 22, 2023 08:25
@wipawel wipawel merged commit 2476d94 into KernelTestFramework:mainline Aug 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants