Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

folder structure update / sln update #7

Merged
merged 6 commits into from
Dec 12, 2023

Conversation

tkrch
Copy link
Collaborator

@tkrch tkrch commented Dec 11, 2023

No description provided.

@seangwright
Copy link
Member

seangwright commented Dec 11, 2023

The folder structure should match what we have for https://github.com/Kentico/xperience-by-kentico-lucene

📁 examples
  |   📁 DancingGoat
  |   📁 DancingGoat.Console
  |   📁 ...
📁 docs
  | 
📁 images
  |   📄 screenshot.jpg
📁 src
  |   📁 Kentico.Xperience.UMT
  |       📄 ...
📁 tests
  |   📁 Kentico.Xperience.UMT.Tests
  |       📄 ...

Is Kentico.Xperience.UMT.Example.AdminApp meant to represent an XbyK application?

If the integration is meant to be deployed into an XbyK solution, we should have an example DancingGoat application in the repository (under /examples) that a developer can use to test.

@tkrch
Copy link
Collaborator Author

tkrch commented Dec 12, 2023

@seangwright I will change it accordingly.
Yes, "Kentico.Xperience.UMT.Example.AdminApp" is meant to represent XbyK application - only sample. If current state of sample app should break release of "Kentico.Xperience.UMT" nuget package, i will delete it until its fixed..

@tkrch
Copy link
Collaborator Author

tkrch commented Dec 12, 2023

@seangwright the application itself (Kentico.Xperience.UMT.Example.AdminApp) is sample - it is not intended for production use

@tkrch
Copy link
Collaborator Author

tkrch commented Dec 12, 2023

@seangwright solution has now fixed directory structure with correct casing. (if You pull to main, squash commits - some changes were reverted)

@seangwright seangwright merged commit 7db1fc4 into main Dec 12, 2023
1 check passed
@seangwright seangwright deleted the feat/folder-structure-cleanup branch December 12, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants