admin sample design + samples json #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seangwright
reviewed
Sep 6, 2023
| */ | ||
|
|
||
| // Defines a new application and registers its root page under <webappdomain>/admin/CustomTemplate | ||
| [assembly: UIApplication("UMT.index", typeof(UniversalMigrationTemplate), "universal-migration-toolkit", "Universal migration toolkit", UmtWebAdminModule.CustomCategory, Icons.Clock, "@umt/web-admin/CustomLayout")] |
There was a problem hiding this comment.
I would like to talk with the dev team about conventions for naming modules that come from Kentico.
Ex:
@umt/web-admin/...@kentico/umt-web-admin/...@kentico-umt/web-admin/...
There was a problem hiding this comment.
Here's the feedback from Jakub O.
- anything officially supported by Kentico and part of the product portfolio should use the Kentico prefix.
- integration packages should avoid using general naming as much as possible.
❌Bad
@Kentico/Search
Kentico.Xperience.Search
@kentico/web-admin✔ Good
@Kentico/Lucene-Search
Kentico.Xperience.LuceneSearch
@kentico/umt-web-admin
I think this means we should name the client package @kentico/umt-web-admin
|
work on this PR was halted until further work is approved |
|
closing, this PR is obsolete due to changes in XbyK APIs and change in plans how will admin sample be implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.