-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: use standard ASPNET Core namespace for extensions #6
Conversation
This PR requires #5 to be merged first, because the repository contains an extra |
This created unused using in Dancing goat Program.cs. I have pushed a fix. Otherwise this is fine with me. |
@@ -44,10 +44,10 @@ stages: | |||
variables: | |||
- group: Code Sign KV Auth | |||
|
|||
- name: Configuration | |||
value: Release | |||
- name: ProjectFolder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change in indentation has broke the azure pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixed in #5
Motivation
All DI related extension methods (extensions on
IServiceCollection
) should be in the same namespace -Microsoft.Extensions.DependencyInjection
. This makes it easier for developers to find these extensions when they are configuring dependencies.This PR updates the extensions in this library to follow that convention.
Checklist
How to test
n/a