modify recommendation assertion. #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…daOS/SynapseML into keerthiyanda/spark3.4
Add line to delete the azure search index before recreating it because "put" fails on the index if one already exists. (cherry picked from commit 214060c)
|
@BrendanWalsh Hi Brendan, can you help to review it? Thanks. |
BrendanWalsh
suggested changes
Aug 31, 2023
| @@ -24,4 +39,18 @@ class RankingAdapterModelSpec extends RankingTestBase with TransformerFuzzing[Ra | |||
| } | |||
|
|
|||
| override def reader: MLReadable[_] = RankingAdapterModel | |||
|
|
|||
| override def assertDFEq(df1: DataFrame, df2: DataFrame)(implicit eq: Equality[DataFrame]): Unit = { | |||
There was a problem hiding this comment.
unless i'm missing something this is the same as above. can we reduce code duplication?
| @@ -15,6 +17,19 @@ class RankingAdapterSpec extends RankingTestBase with EstimatorFuzzing[RankingAd | |||
|
|
|||
| override def modelReader: MLReadable[_] = RankingAdapterModel | |||
|
|
|||
| override def assertDFEq(df1: DataFrame, df2: DataFrame)(implicit eq: Equality[DataFrame]): Unit = { | |||
| def prep(df: DataFrame) = { | |||
| // sort rows and round decimals before compare two dataframes | |||
There was a problem hiding this comment.
With the goal of making sure that we're not hiding a real issue by changing tests, are we sure it's accurate to sort and round?
Why did it work before when it was unsorted and unrounded?
KeerthiYandaOS
force-pushed
the
keerthiyanda/spark3.4
branch
from
b6f0551 to
f59a40c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.