Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Improved log output for mod loading #527

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dunkhan
Copy link

@Dunkhan Dunkhan commented May 13, 2016

Commit message:
Added logging for loading of all components, cubeblocks an voxel materials in mods
Supressed 'None extensions' logging when empty extensions array was passed on purpose
Added prefab path to prefab logging
Fixed issue where contentFile was set to null before being logged in 'Resource not found' log message

Explanation:
Troubleshooting XML mods is very difficult, usually the current version just says which file failed, and in some mods where files can reach thousands of lines with just a handful of added blocks, this can result in a lot of trial and error before finding the errors in the xml. This changeset logs the name of each component, voxel material and cubeblock as it is loaded so that it can be seen which one has failed.
The changes also include a cleanup of the existing debug output including the spam of 'Loading prefab' messages and the 'None file extensions' spam which should be familiar to most modders.

…rials in mods

Supressed 'None extensions' logging when emtpy extensions array was passed on purpose
Added prefab path to prefab logging
Fixed issue where contentFile was set to null before being logged in 'Resource not found' log message
@Jimmacle
Copy link

Jimmacle commented May 15, 2016

If only all PRs were as clear as this. Nice work!

@Dunkhan
Copy link
Author

Dunkhan commented Jul 22, 2016

I checked the conflict and it is nothing. Basically an output string has slightly different text in my branch. When merging you can take either version it should not make a difference.

Let me know if you want me to resolve this myself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants