Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve session handling #43

Merged
merged 5 commits into from
Feb 10, 2015
Merged

Improve session handling #43

merged 5 commits into from
Feb 10, 2015

Conversation

fprochazka
Copy link
Member

  • drop 5.3, because aint nobody got time for making it work without SessionHandlerInterface
  • SessionHandler implements SessionHandlerInterface instead of Nette\Http\ISessionStorage ... as this as literary "internal" class and you should not interact with it in any way, this is not considered a BC Break
  • handler throws SessionHandlerException, that you can catch
  • load of new consistency tests for the Handler including integration tests

Related: nette/http#50, nette/http#51


Next step: #44

@fprochazka fprochazka self-assigned this Feb 10, 2015
@fprochazka fprochazka changed the title Fixed sessions Improve session handling Feb 10, 2015
fprochazka added a commit that referenced this pull request Feb 10, 2015
@fprochazka fprochazka merged commit e52b2ec into master Feb 10, 2015
@fprochazka fprochazka deleted the fixed-sessions branch February 10, 2015 17:19
@fprochazka
Copy link
Member Author

Even through I've merged this, you can still comment on things and I'd be happy to fix them :)

@fprochazka
Copy link
Member Author

Fix 2448b08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant