-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Improved performance of journal cleaning #40
base: master
Are you sure you want to change the base?
Conversation
Great, but I won't have time to look into this till at least friday. Would you mind doing the first review @matej21 ? :) |
Jen par poznamek v cestine, sorry :)
|
98c1b5e
to
9f2d16b
Compare
I see the relation in the way that there have been some data omitted in Redis. However you are right now. I have updated the implementation to make it work as expected. New speed of PHP implementation is 0.6 seconds on average for the same testing data. |
Commit b0fae69 has much better performance (0,16 s in Lua, 0,12 s in PHP). However it leaves a lot of journal data in Redis to be removed by something else. Let's call it "garbage collector". If it could be a good way then I can prepare code which deletes these orphans. I have some idea how to do it. |
It is also possible to add garbage collection requiring (and very fast) as optional in configuration. All comments and ideas are welcome. |
Refs #21
Performance testing
PHP
Lua
disadvantage