feat(statedb): Add initial module setup with base StateDB #1806
Conversation
There was a problem hiding this comment.
Standalone workflow for testing statedb since I don't think it needs to be run when non-statedb code is modified
| // it's safer to use than using journal index alone. | ||
| type revision struct { | ||
| id int | ||
| journalIndex int |
There was a problem hiding this comment.
int64 for more headroom (unless the indices are reset every block then unlikely we run out of them)?
There was a problem hiding this comment.
The modified StateDB is in -> Kava-Labs/ethermint#33
This one is just a 1:1 copy of the existing StateDB we are already using via Ethermint without any changes to for the setup
| // Snapshot and RevertToSnapshot. | ||
| journal *journal | ||
| validRevisions []revision | ||
| nextRevisionID int |
There was a problem hiding this comment.
int64 for more headroom (unless the revisions are reset every block then unlikely we run out of them)?
| refund uint64 | ||
|
|
||
| // Per-transaction logs | ||
| logs []*ethtypes.Log |
There was a problem hiding this comment.
depending how often these are referenced, suggest using a map with the tx hash as the key (and the slice of logs for that tx as the value ofc)
| logs []*ethtypes.Log | ||
|
|
||
| // Per-transaction access list | ||
| accessList *accessList |
There was a problem hiding this comment.
similar comment regarding map indexed by most popular look up key
| func (s *StateDB) GetCommittedState(addr common.Address, hash common.Hash) common.Hash { | ||
| stateObject := s.getStateObject(addr) | ||
| if stateObject != nil { | ||
| return stateObject.GetCommittedState(hash) |
There was a problem hiding this comment.
all of these Getters would be more idiomatic golang if they returned an error for when the value wasn't in state (potentially even a typed error to allow callers to decide whether they are okay with the default value for a non-existent key
There was a problem hiding this comment.
StateDB needs to implement the StateDB interface from geth so there isn't much flexibility on return values https://github.com/ethereum/go-ethereum/blob/v1.10.26/core/vm/interface.go
| // getStateObject retrieves a state object given by the address, returning nil if | ||
| // the object is not found. | ||
| func (s *StateDB) getStateObject(addr common.Address) *stateObject { | ||
| // Prefer live objects if any is available |
There was a problem hiding this comment.
assuming live objects are always latest / non-stale version of the state object we care about?
| newObj, prev := s.createObject(addr) | ||
| if prev != nil { | ||
| newObj.setBalance(prev.account.Balance) | ||
| } |
There was a problem hiding this comment.
wait where is newObj returned or is this a method that is called only for it's side effects?
Description
Adds:
ethdirectory - if we also want to add custom precompiles under therev0.21.0-kava-v23-1Checklist