Add auction bot module #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boodyvo
requested review from
pirtleshell,
nddeluca,
karzak,
sesheffield and
drklee3
boodyvo
commented
Aug 26, 2024
| github.com/go-chi/chi/v5 v5.0.8 | ||
| github.com/joho/godotenv v1.4.0 | ||
| github.com/kava-labs/go-tools/signing v0.0.0-20240404001505-7ad3de810cdd | ||
| github.com/kava-labs/go-tools/signing v0.0.0-20240729153035-2e263b3a24d2 |
There was a problem hiding this comment.
The version with updated dependencies
boodyvo
commented
Aug 27, 2024
| @@ -0,0 +1,170 @@ | |||
| //go:build integration | |||
There was a problem hiding this comment.
This is same test as was in testing file, where we check signer (here more for validation of signature and the transactions are passing)
drklee3
reviewed
Aug 27, 2024
Comment on lines
+37
to
+38
| test-integration: | ||
| cd signing/testing && go test -v -tags=integration -count=1 |
There was a problem hiding this comment.
Should this be moved to the signing specific Makefile?
There was a problem hiding this comment.
Not sure if it make sense. If we will extend integration test to other modules it's easier to run one integration test for all of them with just make test-integration, than running it directory b directory, so would prefer to keep one common make command in the root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auction-botand as a resultsigningto use cometbft, cossmos-sdk v0.47.10 and kava v0.26.1.spammerswitched to already used logrus (just updated imports)