Pass enabled precompiles to geth #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniy-scherbina
force-pushed
the
yevhenii/enabled-precompiles
branch
from
2a06865 to
041336b
Compare
drklee3
reviewed
May 28, 2024
| @@ -223,7 +223,7 @@ replace ( | |||
| github.com/99designs/keyring => github.com/cosmos/keyring v1.2.0 | |||
| // Use cosmos-sdk fork with staking transfer events, and custom tally handler support | |||
| github.com/cosmos/cosmos-sdk => github.com/kava-labs/cosmos-sdk v0.47.10-kava.2 | |||
| github.com/ethereum/go-ethereum => github.com/Kava-Labs/go-ethereum v1.10.27-0.20240308170502-da7973e5eee0 | |||
| github.com/ethereum/go-ethereum => github.com/Kava-Labs/go-ethereum v1.10.27-0.20240513233504-6e038346780b | |||
There was a problem hiding this comment.
If it relies on a specific geth git hash / pr, it would be useful to link to it in the pr description 😄 so its easier to track which requires which
There was a problem hiding this comment.
No, it relies on latest commit of kava/release/1.10/ which is our main branch in geth fork.
So basically I just updated geth dependency, because I needed NewEVMWithEnabledPrecompiles which we recently merged into geth fork.
| @@ -138,6 +138,15 @@ func (p Params) EIPs() []int { | |||
| return eips | |||
| } | |||
|
|
|||
| func (p Params) EnabledPrecompileAddrs() []common.Address { | |||
There was a problem hiding this comment.
Add doc comment for public method, and some basic tests would be good
drklee3
approved these changes
May 30, 2024
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.