Initialize precompiles in UpdateParams #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
evgeniy-scherbina
force-pushed
the
yevhenii/boilerplate-precompile-v3
branch
2 times, most recently
from
62432f9 to
b38c516
Compare
evgeniy-scherbina
changed the title
evgeniy-scherbina
force-pushed
the
yevhenii/boilerplate-precompile-v3
branch
4 times, most recently
from
357e30a to
208eaa5
Compare
evgeniy-scherbina
force-pushed
the
yevhenii/boilerplate-precompile-v3
branch
from
208eaa5 to
f7e532b
Compare
drklee3
reviewed
May 28, 2024
| if err := k.SetParams(ctx, req.Params); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return &types.MsgUpdateParamsResponse{}, nil | ||
| } | ||
|
|
||
| func (k *Keeper) updatePrecompiles(ctx sdk.Context, newEnabledPrecompiles []string) error { |
There was a problem hiding this comment.
Should we return an error if the precompile contract isn't registered in the geth precompile modules (RegisteredModules())?
Also small optional thing: I think this could be moved to a separate file, just feels it could be separate from the msg_server
Comment on lines
+167
to
173
| if err := k.updatePrecompiles(ctx, req.Params.EnabledPrecompiles); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if err := k.SetParams(ctx, req.Params); err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
updatePrecompiles() naming a bit vague in usage here since it's also set in state in SetParams() - could optionally rename to something more specific / different from just updating/setting like initializePreocmpiles
evgeniy-scherbina
force-pushed
the
yevhenii/boilerplate-precompile-v3
branch
from
a0d627e to
b64b3fd
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.