Extend x/evm module params with enabled_precompiles #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniy-scherbina
force-pushed
the
extend-evm-module
branch
2 times, most recently
from
0539c29 to
b9a0598
Compare
evgeniy-scherbina
force-pushed
the
extend-evm-module
branch
from
dea0f38 to
5b6405e
Compare
evgeniy-scherbina
force-pushed
the
extend-evm-module
branch
from
5b6405e to
f385a8d
Compare
evgeniy-scherbina
force-pushed
the
extend-evm-module
branch
from
d04de80 to
6e25d37
Compare
evgeniy-scherbina
force-pushed
the
extend-evm-module
branch
2 times, most recently
from
1552ed6 to
29122ea
Compare
evgeniy-scherbina
force-pushed
the
extend-evm-module
branch
2 times, most recently
from
556bfe6 to
7905fcf
Compare
evgeniy-scherbina
force-pushed
the
extend-evm-module
branch
from
7905fcf to
30aaf56
Compare
drklee3
reviewed
May 1, 2024
drklee3
reviewed
May 1, 2024
evgeniy-scherbina
force-pushed
the
extend-evm-module
branch
from
0af7b85 to
c8f023e
Compare
drklee3
reviewed
May 1, 2024
evgeniy-scherbina
force-pushed
the
extend-evm-module
branch
from
43ad1cf to
770e0ba
Compare
nddeluca
reviewed
May 2, 2024
nddeluca
approved these changes
May 2, 2024
pirtleshell
approved these changes
May 2, 2024
x/evm/types/params.go
Outdated
| // IsLondon returns if london hardfork is enabled. | ||
| func IsLondon(ethConfig *params.ChainConfig, height int64) bool { | ||
| return ethConfig.IsLondon(big.NewInt(height)) | ||
| } | ||
|
|
||
| func CheckIfEnabledPrecompilesAreRegistered(registeredModules []precompile_modules.Module, enabledPrecompiles []string) error { |
There was a problem hiding this comment.
need comment on public method
also maybe a name like ValidateEnabledPrecompiles or ValidatePrecompileRegistration is more idiomatic (and future proof?)
There was a problem hiding this comment.
agree, ValidatePrecompileRegistration sounds better
x/evm/types/params.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func checkIfSortedInBytesRepr(addrs []common.Address) error { |
There was a problem hiding this comment.
nit: validate might be more consistent naming here and below than checkIf
There was a problem hiding this comment.
agree, validateSortingInBytesRepr and validateUniquenessInBytesRepr sounds better
also validateOrderInBytesRepr sounds good, but I went with validateSortingInBytesRepr
Fixed: 27126aa
evgeniy-scherbina
force-pushed
the
extend-evm-module
branch
from
fe885c3 to
e749630
Compare
evgeniy-scherbina
force-pushed
the
extend-evm-module
branch
from
e749630 to
013442b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x/evmparams withenabled_precompilesenabled_precompilesinInitGenesis