Fix CI jobs #43
Merged
Fix CI jobs #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove depguard from golangci-lint * Remove cachix/cachix-action step in integration_tests job * Remove cachix/cachix-action step from gomod2nix * Remove cachix/cachix-action step from python-lint * Remove cache upload job * Trigger ci tests * Use go 1.20 for iavl v1 * Use go 1.20 in ci * Fix yaml parsing 1.20 * Resolve lint issues * Update ibc-go to v6.1.1, [email protected] Matches kava, suppresses vuln errors * Exclude .pb.go from lll linter * Resolve unused lint errors * Add get-diff-action step to integration tests * Update integration_tests nix setup * Add nix-community/cache-nix-action for integration tests * test: Fix tracing tests mock error * ci: Remove codecov upload * Add goleveldb replace directive to fix version not found errors in test-rpc * Use json string instead of byte array for tests data clarity * Ignore lint lll error on server.FlagAPISwagger * Resolve lint errors * fix: tx trace gasUsed camel case instead of snake * Prevent modifying trace response if missing fail or non gas error * Add note for tracing test * Revert tracing changes with minimum fix Avoid large diff and keep it the same for now * gofumpt * test: Update test_pruned_node expected error integration test * Handle connection refused error in integration test * Restore jose2go version in gomod2nix.toml * Resolve flake8 lint errors on integration tests * Add -I nixpkgs=./nix to integration Makefile
This was referenced Apr 1, 2024
evgeniy-scherbina
force-pushed
the
yevhenii/ci-improvements-nix-v2
branch
from
1a90160 to
088661b
Compare
evgeniy-scherbina
force-pushed
the
yevhenii/ci-improvements-nix-v2
branch
from
7319f9d to
8c395ac
Compare
evgeniy-scherbina
force-pushed
the
yevhenii/ci-improvements-nix-v2
branch
from
e23cd48 to
5a17ea8
Compare
drklee3
reviewed
Apr 9, 2024
drklee3
approved these changes
Apr 10, 2024
nddeluca
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
genutil.NewAppModuleBasic(genutiltypes.DefaultMessageValidator)instead ofgenutil.AppModuleBasic{}govKeeper.SetLegacyRouter(govRouter)baseapp.SetChainID(chainID)go1.21.6->go1.21.0to avoid nix-related errorsgomod2nix.tomlnix-shell -I nixpkgs=./nix ./tests/integration_tests/shell.nixgomod2nix generate(inside nix-shell)panic: error generating pkgs: go.mod:5: unknown directive: toolchain;testenv.nixignores version ofpoetry2nixwhich specified insources.json, so I had to explicitly pass it totestenv.nix:(_: pkgs: { test-env = pkgs.callPackage ./testenv.nix { poetry2nix = import sources.poetry2nix {}; }; })buildGo120Module -> buildGo121Modulesources.json:tests/integration_tests/configs/upgrade-test-package.nixwhich affectstest_cosmovisor_upgradetests/integration_tests/test_grpc_only.py, partially copy-pasted from cronos's ethermint.tests/integration_tests/test_upgrade.pyNOTE:Steps to reproduce regenerating of
gomod2nix.toml:flake.nixin root of ethermint, source code: How to use this with go 1.21? nix-community/gomod2nix#134 (comment)nix develop --extra-experimental-features nix-command --extra-experimental-features flakesgomod2nixinside develop shellnix flakeUPD:gomod2nix.tomlwas resolved