-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CentOS 10, Debian 11 and openSUSE 15 tests #162
Conversation
evgeni
commented
Jul 16, 2024
- don't set max-parallel 1, run all the tests in parallel
- fail-fast: false - run all tests even if some fail
- add EL10 testing
- use native unittest, unittest2 was a backport for pre 2.7 python
- stop using deprecated imp -- import and ImportError is enough
- properly skip DNF related tests when DNF is not available
- Add Debian 11 tests
EL6 is failing, but that will be removed in #161 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some good cleanups here. I still think this repository has poor abstraction. Ideally we'd have some base class and then for each "backend" an implementation. Some changes I made in the past moved in this direction, but it's not there yet.
ZYPPER = True | ||
except ImportError: | ||
ZYPPER = False | ||
|
||
try: | ||
imp.find_module('yum') | ||
import yum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you change it to this, then this part becomes redundant:
katello-host-tools/src/katello/enabled_report.py
Lines 5 to 6 in ecd9b1a
if YUM: | |
import yum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how so? it would then need to from katello.constants import yum
instead…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, Ruby has created some brain damage where I assumed it was present in a global namespace.