-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins): adds testnet address for unruggable #56
base: main
Are you sure you want to change the base?
feat(plugins): adds testnet address for unruggable #56
Conversation
config/agents/default.agent.json
Outdated
"allowed_internal_tools": ["get_balance", "get_own_balance", "swap_tokens"] | ||
"external_client": [], | ||
"allowed_external_client_tools": [], | ||
"allowed_internal_tools": ["get_balance", "get_own_balance", "swap_tokens", "create_memecoin", "launch_on_ekubo"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you rather implement a specific config for unruggable agents under config/agents/unruggable.agent.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was using this config for manual testing but sure
.env.example
Outdated
@@ -1,4 +1,5 @@ | |||
# Starknet configuration (mandatory) | |||
STARKNET_NETWORK=testnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you keep an exemple value here like YOUR_STARKNET_NETWORK
@ZackAttax Actually, I’m not sure if relying on an environment variable for the network is the right solution since "mainnet" could be defined as:
Each plugin could define it in its own way if we don’t enforce a standard. But the problem is that limiting it to just "mainnet" and "testnet," for example, would break compatibility with App Chains. One possible solution to ensure a unique source of truth would be for Users would then have to implement it as follows: export const getNetworkFactoryAddress = (agent: StarknetAgentInterface) => {
const network = agent.getNetwork();
return network === 'SN_MAIN'
? FACTORY_ADDRESS_MAINNET
: FACTORY_ADDRESS_TESTNET;
}; The only cons is that it is a bit more low level for users and devs but way more exportable accross all networks. |
No description provided.