Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't wait for discord api initialise. #176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TiBarification
Copy link

no need to force server spam connection errors while we didn't fully connected to discord api

no need to force server spam connection errors while we didn't fully connected to discord api
@KarlOfDuty
Copy link
Owner

I don't know if this is a great idea, many thing in the bot assume that the discord client is set up before starting to send messages.

I also don't understand exactly what the issue is? It takes less than a second for the bot to start, if I start both the bot and server at the same time I haven't ever seen any connection errors? And the plugin only tries to connect once every 5 seconds anyway, so it would only be one message.

@TiBarification
Copy link
Author

I don't know if this is a great idea, many thing in the bot assume that the discord client is set up before starting to send messages.

I also don't understand exactly what the issue is? It takes less than a second for the bot to start, if I start both the bot and server at the same time I haven't ever seen any connection errors? And the plugin only tries to connect once every 5 seconds anyway, so it would only be one message.

For me I found if bot goes offline or didn't started for some reason , but connection with plugin established, plugin spamming its trying to connect when connection between plugin and discord bot is good, but discordapi wants to go away.

@KarlOfDuty
Copy link
Owner

Are you having connection issues to discord or what do you mean?

I think it is much more likely for discord to work properly than for the server to be up within the first few seconds as most would start the bot first and then the server.

@KarlOfDuty KarlOfDuty self-requested a review September 17, 2024 13:32
@TiBarification
Copy link
Author

Are you having connection issues to discord or what do you mean?

I think it is much more likely for discord to work properly than for the server to be up within the first few seconds as most would start the bot first and then the server.

I had issues with connection to Discord and that change fixes that for me.

@KarlOfDuty
Copy link
Owner

Can you describe your issues? Do you know what causes it? How long is your connection down for? Not being able to connect to discord doesn't seem like it should be a common issue.

I will have to do some testing on this branch, I don't know if accepting connections before the discord client is ready is safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants