fix: add OCaml 5 support #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before OCaml5, hash_variant was defined as an alias for caml_hash_variant in compatibility.h file (#define hash_variant caml_hash_variant) Seems not present in OCaml5 so this patch rename hash_variant to caml_hash_variant.
darlentar
force-pushed
the
add_ocaml5_support
branch
2 times, most recently
from
4a6fc37
to
9c60e5b
Compare
This reverts commit 3065711.
darlentar
force-pushed
the
add_ocaml5_support
branch
from
9c60e5b
to
ee6916b
Compare
|
Needs other changes though as some functions also changed in generated code ( Also need to fix domain lock issues introduced with OCaml5. |
|
It looks like some additional checks has been added in ocaml/ocaml#11506 |
Signed-off-by: Kakadu <[email protected]>
Signed-off-by: Kakadu <[email protected]>
Signed-off-by: Kakadu <[email protected]>
Signed-off-by: Kakadu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before OCaml5, hash_variant was defined as an alias for caml_hash_variant in compatibility.h file
(#define hash_variant caml_hash_variant)
Seems not present in OCaml5 so this patch rename hash_variant to caml_hash_variant.