Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rails-icon): sage icon schema #2003

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix(rails-icon): sage icon schema #2003

merged 2 commits into from
Oct 16, 2024

Conversation

ju-Skinner
Copy link
Collaborator

@ju-Skinner ju-Skinner commented Oct 15, 2024

Description

With icons now being contained in Pine design system, the list of icons will not match the schema in Rails.

Jira Ticket:
https://kajabi.atlassian.net/browse/DSS-895

Screenshots

Before After
image
image

|

Testing in sage-lib

  1. Go to the docs/app/views/examples/components/icon/_preview.html.erb and change an icon to a random string.
  2. Then navigate to http://localhost:4000/pages/component/icon?tab=preview
  3. The page should render, but no icon will be visible. If you put a non-existent icon name.

Copy link
Contributor

github-actions bot commented Oct 15, 2024

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 5 package(s) with unknown licenses.
See the Details below.

License Issues

docs/package.json

PackageVersionLicenseIssue Type
@kajabi/sage-packs^1.1.16NullUnknown License

packages/sage-packs/package.json

PackageVersionLicenseIssue Type
@kajabi/sage-assets^2.0.0NullUnknown License
@kajabi/sage-react^2.0.0NullUnknown License
@kajabi/sage-system^2.0.0NullUnknown License

packages/sage-react/package.json

PackageVersionLicenseIssue Type
@kajabi/sage-assets^2.0.0NullUnknown License
Denied Licenses: LGPL-2.0, AAL, Adobe-2006, Afmparse, Artistic-1.0, Artistic-1.0-cl8, Artistic-1.0-Perl, Beerware, blessing, Borceux, CECILL-B, ClArtistic, Condor-1.1, Crossword, CrystalStacker, diffmark, DOC, EFL-1.0, EFL-2.0, Fair, FSFUL, FSFULLR, Giftware, HPND, IJG, Leptonica, LPL-1.0, LPL-1.02, MirOS, mpich2, NASA-1.3, NBPL-1.0, Newsletr, NLPL, NRL, OGTSL, OLDAP-1.1, OLDAP-1.2, OLDAP-1.3, OLDAP-1.4, psutils, Qhull, Rdisc, RSA-MD, Spencer-86, Spencer-94, TU-Berlin-1.0, TU-Berlin-2.0, Vim, W3C-19980720, W3C-20150513, Wsuipa, WTFPL, xinetd, Zed, Zend-2.0, ZPL-1.1, AGPL-1.0-only, AGPL-1.0-or-later, AGPL-3.0-only, AGPL-3.0-or-later, APSL-1.0, APSL-1.1, APSL-1.2, APSL-2.0, CPAL-1.0, EUPL-1.0, EUPL-1.1, EUPL-1.2, NPOSL-3.0, OSL-1.0, OSL-1.1, OSL-2.0, OSL-2.1, OSL-3.0, RPSL-1.0, SSPL-1.0, CAL-1.0, CAL-1.0-Combined-Work-Exception, Parity-6.0.0, Parity-7.0.0, RPL-1.1, RPL-1.5, EPL-1.0, EPL-2.0, ErlPL-1.1, IPL-1.0, LGPL-2.0-only, LGPL-2.0-or-later, LGPL-2.1-only, LGPL-2.1-or-later, LGPL-2.1, LGPL-3.0-only, LGPL-3.0-or-later, LGPL-3.0, MPL-1.0, MPL-1.1, MPL-2.0, MPL-2.0-no-copyleft-exception, MS-RL, SPL-1.0, BSD-Protection, copyleft-next-0.3.0, copyleft-next-0.3.1, GPL-1.0-only, GPL-1.0-or-later, GPL-1.0, GPL-2.0-only, GPL-2.0-or-later, GPL-2.0, GPL-3.0-only, GPL-3.0-or-later, GPL-3.0, QPL-1.0, Sleepycat

Scanned Manifest Files

docs/package.json
  • @kajabi/sage-packs@^1.1.16
  • @kajabi/sage-packs@^1.1.15
packages/sage-packs/package.json
  • @kajabi/sage-assets@^2.0.0
  • @kajabi/sage-react@^2.0.0
  • @kajabi/sage-system@^2.0.0
  • @kajabi/sage-assets@^1.15.7
  • @kajabi/sage-react@^1.20.7
  • @kajabi/sage-system@^1.3.6
packages/sage-react/package.json
  • @kajabi/sage-assets@^2.0.0
  • @kajabi/sage-assets@^1.15.7

@ju-Skinner ju-Skinner requested a review from a team October 15, 2024 10:47
@ju-Skinner ju-Skinner self-assigned this Oct 15, 2024
@ju-Skinner ju-Skinner force-pushed the fix/sage-icon-schema branch from 94b3955 to 41e1853 Compare October 15, 2024 10:47
@ju-Skinner ju-Skinner force-pushed the fix/sage-icon-schema branch from 41e1853 to f532c54 Compare October 15, 2024 10:48
@pixelflips pixelflips requested a review from a team October 15, 2024 10:54
@ju-Skinner ju-Skinner merged commit b702935 into develop Oct 16, 2024
6 of 7 checks passed
@ju-Skinner ju-Skinner deleted the fix/sage-icon-schema branch October 16, 2024 13:23
@ju-Skinner ju-Skinner mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants