Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): update dropdown breakpoint #1823

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

QuintonJason
Copy link
Contributor

Description

  • Resolve dropdowns getting cut off on contact ui

Screenshots

Before After
Screenshot 2023-10-16 at 12 23 05 PM Screenshot_2023-10-16_at_12_22_54 PM

Testing in sage-lib

  • Visit the dropdown Rails page
  • Set your browser height to less than 775px tall and verify that the dropdown menu max-height is smaller

Testing in kajabi-products

  1. (MEDIUM) Reduce Dropdown menu size on smaller screens.

Related

AUDS-933

@QuintonJason QuintonJason self-assigned this Oct 19, 2023
@QuintonJason QuintonJason requested a review from a team October 19, 2023 19:33
@QuintonJason QuintonJason marked this pull request as ready for review October 19, 2023 19:33
Copy link
Collaborator

@monicawheeler monicawheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@QuintonJason QuintonJason merged commit e7c616a into develop Oct 19, 2023
4 checks passed
@QuintonJason QuintonJason deleted the AUD-933/qj-contact-ui-cut-off-small-screens-1 branch October 19, 2023 21:19
@QuintonJason QuintonJason mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants