Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styles(chip): update chips to use border #290

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

monicawheeler
Copy link
Contributor

@monicawheeler monicawheeler commented Nov 8, 2024

Description

To align more closely with the alert design pattern, chip now has a border. Figma file that displays necessary changes.

Fixes #(issue)
DSS-1159

Type of change

  • Update background color variable
  • Add border color variable
  • Assign border color to all chips
  • Increase dot size
  • Decrease height with padding-block and padding-inline
  • Adjust line-height to 20px, rather than 21px
  • Removed spacing related to the close button to avoid awkward overlapping close hover state
  • Font family updated to align with Design, Inter for default size chips, Greet for larger size chips

Screenshots

Before After
Screenshot 2024-11-08 at 12 42 17 PM Screenshot 2024-11-08 at 12 41 58 PM

Please delete options that are not relevant.
If your type of change is not present, add that option.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests you've added and run to verify your changes.
Provide instructions so that we can reproduce.
Please also list any relevant details for your test configuration.

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@monicawheeler monicawheeler self-assigned this Nov 8, 2024
@github-actions github-actions bot added the package: core Changes have been made to the Core package label Nov 8, 2024
Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit f7497ac
🔍 Latest deploy log https://app.netlify.com/sites/pine-design-system/deploys/672e6fe9bef51f000816f43e
😎 Deploy Preview https://deploy-preview-290--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ju-Skinner ju-Skinner force-pushed the main branch 4 times, most recently from bab7cd1 to 05e3572 Compare February 3, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core Changes have been made to the Core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant