Namespace Changes for Nylas -> Nylasv2 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add workflow step to upload to codecov * Upgrade simplecov gem version * Add simplecov formatter for codecov * Point the codecov step to the coverage file * Pretti-fy the readme and add shields
This PR adds the timezone, start_timezone and end_timezone fields. This SDK also now uses tzinfo as a dev dependency to validate the strings set by the user are indeed IANA database names.
* Adds visibility attribute in Event.rb
Add support for the new colors field in the Calendar model. Please note that this field is read only, and for Microsoft calendars only.
This PR adds support for rate limit 429 headers from the API.
…_url (nylas#395) * Issue-394: Add disable_provider_selection kwarg to Api.authentication_url We need the option to disable the "Select different provider" button in Nylas' hosted auth when we are trying to authenticate against a specific provider. This is necessary to prevent our users from escaping the intended auth flow and selecting a provider that we do not support. This commit addresses this need by adding and optional keyword argument to the Api.authentication_url method and, if it is provided, including it in the params payload appended on the call to the /oauth/authorize endpoint. Tests have been added to account for this change and I tested it locally to confirm that the "Select different provider" button was no longer visible when I included disable_provider_selection: true in my call to the authentication_url method. * Fix Rubocop linter complaint MethodTooLong Co-authored-by: Mostafa Rashed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR just does a bulk find and replace for all
Nylasconstants toNylasV2so that we can bundle this gem along with its v6 version from NylasLicense
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.