fixed shit

gradle.properties

@@ -9,5 +9,5 @@ archives_base_name = effective_advancements
 
 # Dependencies are managed at gradle/libs.versions.toml
 cc_version = 5.0.1
-modmenu_version = 4.0.4
+modmenu_version = 4.0.6
 clothconfig_version = 8.0.75

gradle/libs.versions.toml

@@ -1,10 +1,10 @@
 [versions]
 # The latest versions are available at https://lambdaurora.dev/tools/import_quilt.html
-minecraft = "1.19"
-quilt_mappings = "1.19+build.1"
-quilt_loader = "0.17.0"
+minecraft = "1.19.1"
+quilt_mappings = "1.19.1+build.2"
+quilt_loader = "0.17.1"
 
-quilted_fabric_api = "2.0.0-beta.5+0.57.0-1.19"
+quilted_fabric_api = "4.0.0-beta.1+0.58.5-1.19.1"
 
 [libraries]
 minecraft = { module = "com.mojang:minecraft", version.ref = "minecraft" }

src/main/java/io/github/KacyBiscuit/effective_advancements/AdvancementEffectCommand.java

@@ -45,18 +45,6 @@ public static void register() {
 
 
 		});
-/*
-		CommandRegistrationCallback.EVENT.register(((dispatcher, buildContext, environment) -> {
-			dispatcher.register(literal("debug")
-					.executes((context -> {
-						StatusEffectManager manager = context.getSource().getPlayer().getComponent(StatusEffectComponents.MANAGER);
-						for (AdvancementEffect effect: manager.advancementEffects) {
-							System.out.println(effect.toString());
-						}
-						return 1;
-					})));
-		}));
-*/
 	}
 
 	private static int action(CommandContext<ServerCommandSource> context, boolean remove, boolean debuff, boolean random, int everything) throws CommandSyntaxException {

src/main/java/io/github/KacyBiscuit/effective_advancements/EffectList.java

@@ -10,8 +10,6 @@
 
 import java.util.ArrayList;
 import java.util.Map;
-import java.util.Objects;
-import java.util.function.Consumer;
 
 public class EffectList extends ArrayList<AdvancementEffect> {
 	public ArrayList<AdvancementEffect> toRemove = new ArrayList<>();
@@ -63,6 +61,9 @@ public void amplify(StatusEffect effect, int mod) {
 
 	public boolean has(StatusEffect effect) {
 		for(AdvancementEffect advancementEffect : this) {
+			if(advancementEffect.getType() == null) {
+				break;
+			}
 			if(advancementEffect.getType().equals(effect)) {
 				return true;
 			}

src/main/java/io/github/KacyBiscuit/effective_advancements/StatusEffectManager.java

@@ -32,9 +32,6 @@ public static StatusEffect randomEffect(boolean debuff) {
 
 	public void grant(boolean debuff) {
 		add(randomEffect(debuff));
-		for(AdvancementEffect effect : effects) {
-			System.out.println(effect);
-		}
 	}
 	public void revoke(boolean debuff) {
 		boolean complete = false;
@@ -49,9 +46,7 @@ public void revoke(boolean debuff) {
 
 	public void clearType(boolean debuff) {
 		effects.forEach((effect) -> {
-			System.out.println(effect.isDebuff());
 			if(effect.isDebuff() == debuff) {
-				System.out.println(1);
 				remove(effect.getType(), true, false);
 			}
 		});

src/main/java/io/github/KacyBiscuit/effective_advancements/config/EffectiveConfig.java

@@ -8,7 +8,7 @@
 public class EffectiveConfig extends WrappedConfig {
 
 	@Comment("The Advancements that cause random buffs to be applied.")
-	public final ValueList<String> advancementList = ValueList.create("",
+	public final ValueList<String> advancementList = ValueList.create("Advancement",
 			"story/obtain_armor",
 			"story/form_obsidian",
 			"story/mine_diamond",

src/main/java/io/github/KacyBiscuit/effective_advancements/config/EffectiveConfigScreen.java

@@ -2,6 +2,7 @@
 
 import com.terraformersmc.modmenu.api.ConfigScreenFactory;
 import com.terraformersmc.modmenu.api.ModMenuApi;
+import io.github.KacyBiscuit.effective_advancements.StatusEffectManager;
 import me.shedaniel.clothconfig2.api.ConfigBuilder;
 import me.shedaniel.clothconfig2.api.ConfigCategory;
 import me.shedaniel.clothconfig2.api.ConfigEntryBuilder;