Spillover feature for WashingMachine and Dishwasher
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
val-ismaili
changed the title
WashingMachine and Dishwasher
BramHillebrand
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
I have noticed a few print statements ( I missed them previously). I am not sure this is a good idea. I have for instance sometimes simulated (in a loop) up to a 1000 houses for 30 days. That is potentially a lot of print statements. Is this really valuable information? We hsould consider removing them.
pysimdeum/core/end_use.py
Outdated
| consumption = handle_spillover_consumption(consumption, pattern, start, end, j, ind_enduse, pattern_num, end_of_day, self.name, total_days) | ||
| elif ((day_num + 1) == total_days) and (end > end_of_day): | ||
| difference = end_of_day - start | ||
| print(difference) |
There was a problem hiding this comment.
this print statement should be removed
There was a problem hiding this comment.
oh yes that's not intentionally included, was only there during development. i will remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57
This introduces logic for handling
consumptionanddischargesimulations that extend into a different day (past midnight).User can apply this by running:
Key points here are that:
spilloveris an optional feature. By default, the event will just be cropped out if it extends past the end of simulation.spilloverisTrueand a single day is simulated, the event extending past midnight will spill back into the start of the same day.spilloveris True and multiple days are simulated, if an event extends past midnight that is not the final day in the simulation (e.g. day 2 of 4), it will just carry onto the next day as normal. However, if the event occurs on the final day in the simulation and extends past midnight it will spill back into the start of the simulation on the first day.The value of the
spilloverfeature is that if the user requires, it preserves antecedent conditions for the given time period (number of days) simulated.Note that this is currently only applied to the
WashingMachineandDishwasherappliances.Two day consumption (past midnight on day 1)
Two day discharge (past midnight on day 1)
Three day consumption (past midnight on final day)
Three day discharge (past midnight on final day)