Kitchen Tap discharge

[sophieoneill]

Added the discharge patterns for KitchenTap. It uses the discharge object added in PR #39 . Works exactly the same as the BathroomTap, using a simple discharge flow of consistent discharge flow rate.

Consumption

Discharge

[val-ismaili]

As discussed, this has highlighted the presence of a bug with implementation of discharge object. Issue described here #49

[sophieoneill]

Added fix for simultaneous discharge events bug #49 . when calculating discharge the code checks if the starting discharge flow rate is not zero, if so it will update the start time to the next available zero flow time.

[sophieoneill]

Updated code that fixes the simultaneous discharge event bug, as well as:

• added checks for when the KitchenTap subtype is consumption, the discharge is set to zero, as we assume the water is used for drinking
• added a check for discharge flow equal to 0, and resampling until value is not zero, as there should always be a flow rate (unless consumption/drinking)

Images show high consumption, and a lower flow, as a majority of the events are consumption
Consumption:

Discharge:

[val-ismaili]

@sophieoneill what do you think about adding a flag to the consumption or discharge object. Basically some way that allows the user to know which event in the KitchenTap consumption object is consumption (drinking) vs anything else. so that when comparing the consumption and discharge flow profiles we know that they are correctly linked? I'm not sure the best way of adding this flag though, any ideas?

[sophieoneill]

@val-ismaili I think that's a good suggestion, to add a flag to the consumption or discharge object letting the user know if the event is consumption/drinking, but maybe more of a nice to have at this stage. I have logged it as an issue #55, for a future enhancement.