Add UK data and ability to change country #73
Conversation
|
Note on the data added, most of the info is coming from the At home with water study by the energy saving trust. This study doesn't give us the exact breakdowns of water usage in that same way presented by the NL data. An example of this is frequency of shower use, in the configs it is broken down by age, however in our data we don't have this info, instead it is presented at frequency based on size of household. In cases like this I've used the average frequency across all users. |
| intensity = 0.2 # fixed intensity for bathtub filling corresponds to the maximum water flow at full tap opening [L/s | ||
|
|
||
| [penetration] # penetraton rate of houses with bathtubes [%] depennds on the number of people living in a house | ||
| 1 = 58 |
There was a problem hiding this comment.
I think you're reasoning for using averages across data as per comment makes sense in most cases. However, I think this is an exception - I think it's an unlikely that 58% of single or even 2-person households, have a bathtub, especially given that the penetration for the shower is 100% of households.
|
Can we also add some info to the documentation detailing sources for UK data in the configs and little things like your comment about difference in how data is presented resulting in having to make some assumptions. You could do this by merging this PR and then quickly opening a new one just for docs (this should be quite quick) or you can try pull in changes from the main branch and resolving them. Cause this has been open for a while i think that might be a bit frustrating. Technically the latter is the 'right' way of doing it in most cases, but I would probably opt for the prior in this case. |
In this PR I've added the UK specific data to the repo, as well as adding the functionality that allows the user to change countries stats they want to use.
I've added a folder to
pysimdeum/datafolder that replicates theNLfolder, calledUK. The files are the exact same structurally as NL files, with updates to the data points. The data contained indiurnal_patterns.tomlandhousehold_statistics.tomlis from the Office of National Statistics. A noticeable difference in data collection is that the UK doesn't have a teen age group when recording data, it records as child (0-15) and adult (16+) (usually grouped as 16-24). So any teen results are set to 0.I've added a flag that allows users to specify the country they would like to use stats from when the
built_house()method is called. This is an optional parameter, if not specified NL is used as a default. The user can either inputcountry="UK", which will select the UK folder in the repo, or they can input a local folder and this will be used instead.An example of calling built_house where the directory used is output
Default:
UK:
Local folder:
