Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UK statistics to the repo & update data folder structure #60

Open
sophieoneill opened this issue Feb 18, 2025 · 1 comment · May be fixed by #73
Open

Add UK statistics to the repo & update data folder structure #60

sophieoneill opened this issue Feb 18, 2025 · 1 comment · May be fixed by #73
Assignees
Labels
enhancement New feature or request

Comments

@sophieoneill
Copy link
Collaborator

Add UK based statistics for population, diurnal patterns, water use etc to the repo. To do this we are proposing to update the structure of the pysimdeum/data folder. Rather than adding a second UK folder replicating the NL one, which would result in lots of duplicate .toml files, we would:

  • remove the NL folder, so all files are moved to directly under data
  • Update each file so that it has two layers, NL and UK, with related data under each

The default will be set to NL but with an optional flag that allows the users to use the UK data instead.
@BramHillebrand Does this sound ok?

@sophieoneill sophieoneill self-assigned this Feb 18, 2025
@sophieoneill sophieoneill added the enhancement New feature or request label Feb 18, 2025
@sophieoneill
Copy link
Collaborator Author

After discussions we have decided to add the UK data to the repo by replicating the NL folder structure, not the methodology describe in this issue. This is being done in PR #73

@sophieoneill sophieoneill linked a pull request Feb 27, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant