Switch from Unity's Random to System Random, fix always getting the s…

…ame seeds.
KSP-RO · Nov 15, 2021 · 1182d05 · 1182d05
1 parent 2c757d9
commit 1182d05
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/Source/Engines/ModuleEnginesRF.cs b/Source/Engines/ModuleEnginesRF.cs
@@ -160,6 +160,8 @@ public class ModuleEnginesRF : ModuleEnginesSolver
 
         protected bool started = false; // Track start state, don't handle MEC notification before first start.
 
+        protected static System.Random staticRandom = new System.Random();
+
         #endregion
 
         #region Overrides
@@ -421,8 +423,8 @@ public override void Start()
             {
                 if (partSeed == -1)
                 {
-                    calculatedResiduals = localResidualsThresholdBase + UnityEngine.Random.Range(0f, (float)localVaryResiduals);
-                    partSeed = UnityEngine.Random.Range(0, int.MaxValue);
+                    calculatedResiduals = localResidualsThresholdBase + staticRandom.NextDouble() * localVaryResiduals;
+                    partSeed = staticRandom.Next();
                 }
             }
 

diff --git a/Source/Engines/SolverRF.cs b/Source/Engines/SolverRF.cs
@@ -29,6 +29,7 @@ public class SolverRF : EngineSolver
         private double runVaryIsp = 0d;
         private double runVaryMR = 0d;
         private System.Random seededRandom;
+        private static System.Random staticRandom = new System.Random();
         private bool pressure = true, ullage = true, disableUnderwater;
         private double scale = 1d; // scale for tweakscale
 
@@ -338,7 +339,7 @@ protected double GetRandom(bool useSeed)
             if (useSeed)
                 return seededRandom.NextDouble() * 2d - 1d;
             else
-                return UnityEngine.Random.Range(-1f, 1f);
+                return staticRandom.NextDouble() * 2d - 1d;
         }
 
         protected void GetVariances(bool useSeed, out double varianceFlow, out double varianceMR, out double varianceIsp)