.ksm file optimizations #1733
.ksm file optimizations #1733
Conversation
KOSArgMarker lacked an Equals override so every occurrence of "push ArgMarker" would add another copy of the value to the arguments section of a KSM file.
previousLabel wasn't reset after generating args and before generating the actual code which could have caused issues in the unlikely event that the first instruction's label was the natural successor to the last instruction's label
Switched to using the argument ordinal rather than byte offset to index arguments for each opcode. This allows upto 256 arguments before switching to 2-byte indexes for every opcode, regardless of how long those arguments actually are. If an average encoded argument is 10 bytes long, this will allow 10x as many arguments before hitting the 2-byte threshold, which can translate to several hundred bytes saves in medium sized KSM files.
This is no longer needed
|
I've been reading through some old PR's to see if any can be merged in, or if they are hopelessly too old. I missed it before because it came at a time when we had a lot of things to get out and it would have increased testing burden to suddenly break all compiled KSM's right then. After putting it off, I never got back to it (sorry). I've looked over the changes and all of them look good, but they would also require some changes to this file too: https://github.com/KSP-KOS/KOS/blob/develop/src/kOS.Safe/Compilation/CompiledObject-doc.md (It describes the .ksm format in detail, and your PR would change how arguments are stored, which would make some of what that document says become wrong (i.e. the arg being 20 meaning it's the 20th argument in the pack, rather than the argument at byte position 20).) I like these changes, and if you're still around (I know this is old), would you consider adding edits to that file as part of this PR so they can be accepted as an atomic unit along with the code changes? |
|
Sure thing! I'll see if I can carve out some time in the next couple days to make the doc changes. |
hvacengi
added
the
Pending Documentation
Simple fixes from #1732