Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keymap for Budgy Keyboard #950

Merged
merged 8 commits into from
Mar 30, 2024
Merged

Keymap for Budgy Keyboard #950

merged 8 commits into from
Mar 30, 2024

Conversation

JakobEdvardsson
Copy link
Contributor

@JakobEdvardsson JakobEdvardsson commented Mar 26, 2024

This config has both US-qwerty and Swedish-Colemak-DH in mind.
The default keymap is US-qwerty, in order to switch to the Swedish-Colemak-DH keymap,
comment out the US-qwerty keymap and uncomment the Swedish-Colemak-DH keymap in the main.py file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does qwerty need a seperate kb.py?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix, did not mean to do that

Copy link
Collaborator

@xs5871 xs5871 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're providing two keymaps, wouldn't it make more sense to have common kb.py and main.py, and split off only the keymaps as keymap_sw.py and keymap_us.py for example?

@JakobEdvardsson
Copy link
Contributor Author

If you're providing two keymaps, wouldn't it make more sense to have common kb.py and main.py, and split off only the keymaps as keymap_sw.py and keymap_us.py for example?

You are right! Will make sure to do that instead!

The default keymap is US-qwerty, in order to switch to the Swedish-Colemak-DH keymap, comment out the US-qwerty keymap and uncomment the Swedish-Colemak-DH keymap in the main.py file.
@JakobEdvardsson
Copy link
Contributor Author

@xs5871 made the keymap more modular, all you have to do is to uncomment/comment out an import to change layout.

@xs5871
Copy link
Collaborator

xs5871 commented Mar 28, 2024

There are linter errors that need fixing

@JakobEdvardsson JakobEdvardsson changed the title Swedish - Colemak-DH for Budgy Keyboard Keymap for Budgy Keyboard Mar 29, 2024
@xs5871 xs5871 merged commit 501f616 into KMKfw:master Mar 30, 2024
1 check passed
xs5871 added a commit that referenced this pull request Mar 30, 2024
xs5871 added a commit that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants