KDT5_강동훈 2차과제 #80
Open
KDT5_강동훈 2차과제 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanuuuuu
approved these changes
May 15, 2023
| const theFooter = new TheFooter().el | ||
| const routerView = document.createElement('router-view') | ||
|
|
||
| this.el.append( |
There was a problem hiding this comment.
들여쓰기에 대한 자동설정을 위해서 lint 설정을 제안드립니다:)
lint설정을 통해서 저장시에 자동으로 들여쓰기를 추가할 수 있으니 도입을 검토해보시는 것은 어떨까요? 아래는 VScode의 'lint'설정방법입니다.
| <div class = "the-loader hide"></div> | ||
| ` | ||
|
|
||
| const moviesEl = this.el.querySelector('.movies') |
There was a problem hiding this comment.
영화 목록 태그를 클래스명으로 조회하고 있는데, CSS 특이성에 따르면 구현하신 페이지 내에서 MovieList 컴포넌트는 하나만 사용되므로 클래스명이 아닌 ID를 통해서 요소를 조회하는 것이 더 효율적일 것으로 보입니다. 이와 마찬가지로 아래의 loadEl 또한 ID를 통해서 조회하는 방식을 검토할 수 있을 것 같아요! 클래스명을 사용하여 조회해야한다면 그 이유도 설명해주실 수 있을까요?🤔
|
현재는 단 하나의 커밋으로 모든 변경사항을 반영하고 계신데요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안뇽하세요
js 부분이 아직 많이 부족해서 최대한 강의 보면서 만들었습니다 !