reduce floodding debug output

suppress debug output for invalid address passed to `memoryRead` if it is identical to the last recognized invalid one
KDAB · Nov 5, 2023 · 37065ba · 37065ba
1 parent 2408135
commit 37065ba
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/app/perfunwind.cpp b/app/perfunwind.cpp
@@ -115,7 +115,10 @@ static bool memoryRead(Dwfl *dwfl, Dwarf_Addr addr, Dwarf_Word *result, void *ar
 
     /* Check overflow. */
     if (addr + sizeof(Dwarf_Word) < addr) {
-        qDebug() << "Invalid memory read requested by dwfl" << Qt::hex << addr;
+        if (ui->lastInvalidAddr != addr) {
+            qDebug() << "Invalid memory read requested by dwfl" << Qt::hex << addr;
+            ui->lastInvalidAddr = addr;
+        }
         ui->firstGuessedFrame = ui->frames.length();
         return false;
     }

diff --git a/app/perfunwind.h b/app/perfunwind.h
@@ -103,6 +103,7 @@ class PerfUnwind : public QObject
         QHash<qint32, QHash<quint64, Dwarf_Word>> stackValues;
         QVector<qint32> frames;
         PerfUnwind *unwind;
+        Dwarf_Addr lastInvalidAddr;
         const PerfRecordSample *sample;
         int maxFrames;
         int firstGuessedFrame;