chore: Minor fixes for DebugWidgetViewer_p.h

This class is just used for debug purposes.
KDAB · Jul 17, 2024 · 1f7b78f · 1f7b78f
1 parent d869032
commit 1f7b78f
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/qtwidgets/DebugWidgetViewer_p.h b/src/qtwidgets/DebugWidgetViewer_p.h
@@ -42,7 +42,7 @@ class DebugWidgetViewer : public QWidget
         : QWidget(parent)
     {
         auto pickButton = new QPushButton(QStringLiteral("Pick widget"));
-        pickButton->setObjectName("pick button");
+        pickButton->setObjectName(QStringLiteral("pick button"));
         auto vlay = new QVBoxLayout(this);
         auto hlay = new QHBoxLayout();
 
@@ -63,7 +63,7 @@ class DebugWidgetViewer : public QWidget
 
     void pickWidget()
     {
-        setFilteringEnabled(true);
+        setPickingEnabled(true);
     }
 
     void loadWidget(QWidget *widget)
@@ -77,14 +77,16 @@ class DebugWidgetViewer : public QWidget
         while (p) {
             path.append(p);
             p = p->parentWidget();
+            if (p && p->isWindow())
+                break;
         }
 
         QStandardItem *previous = nullptr;
         for (auto it = path.crbegin(), e = path.crend(); it != e; ++it) {
             QWidget *w = *it;
             QString name = QString::fromLatin1(w->metaObject()->className());
             if (!w->objectName().isEmpty()) {
-                name += "[" + w->objectName() + "]";
+                name += QStringLiteral("[%1]").arg(w->objectName());
             }
 
             auto item = new QStandardItem(name);
@@ -101,21 +103,22 @@ class DebugWidgetViewer : public QWidget
         renderTree();
     }
 
+    /// Event filter for picking
     bool eventFilter(QObject *watched, QEvent *event) override
     {
         if (event->type() != QEvent::MouseButtonPress)
             return false;
 
         if (auto w = qobject_cast<QWidget *>(watched)) {
-            setFilteringEnabled(false);
+            setPickingEnabled(false);
             loadWidget(w);
             return true;
         }
 
         return false;
     }
 
-    void setFilteringEnabled(bool enabled)
+    void setPickingEnabled(bool enabled)
     {
         if (enabled) {
             qApp->setOverrideCursor(Qt::CrossCursor);