Skip to content

Commit

Permalink
ci: Use windows-2019 instead of -latest
Browse files Browse the repository at this point in the history
We've been dealing with an issue in CI, where the test-signal test case
fails when building in Release mode on Windows.
It fails in the ConnectionEvaluator, when it tries to lock the mutex,
which is something that should simply not happen, as the shared_ptr in
the testcase keeps the ConnectionEvaluator alive at the point where the
crash occurs.

In addition, this problem is not reproducable anywhere outside Githubs
CI. If I copy the executable from Github Actions to my local machine,
it simply works.
This leads me to believe this is only a problem with this very specific
Windows environment.
By downgrading our Windows version in CI, we can avoid the problem and
at least continue development.
  • Loading branch information
LeonMatthesKDAB committed Jun 12, 2024
1 parent 856bd49 commit 6d51d32
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
matrix:
os:
- ubuntu-latest
- windows-latest
- windows-2019
- macos-latest

steps:
Expand Down

0 comments on commit 6d51d32

Please sign in to comment.