Fix the OpenGLScreenGrabber for QQuickWidgetOffscreenWindow in Qt6.8+ #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
without this patch:
|
For me at least, the y offset has to be 0, otherwise we grab an offset part of the image. Furthermore, the x offset has to be hidpi adapted too. I cannot test the other Qt versions, so I'll assume this code used to work fine there and only touch this for Qt 6.8+
milianw
force-pushed
the
wip/fix-quick-inspector-quickwidget
branch
from
ceb1dcc to
78161ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For me at least, the y offset has to be 0, otherwise we grab an offset part of the image. Furthermore, the x offset has to be hidpi adapted too.
I cannot test the other Qt versions, so I'll assume this code used to work fine there and only touch this for Qt 6.8+