Skip to content

Commit

Permalink
Upgrade QML Connections {} syntax to functions
Browse files Browse the repository at this point in the history
Old signal handler declaration style is deprecated and spits warnings at
runtime.
  • Loading branch information
ratijas committed Dec 26, 2023
1 parent dc1c04d commit 3727fcc
Showing 1 changed file with 13 additions and 5 deletions.
18 changes: 13 additions & 5 deletions plugins/positioning/mapview.qml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@

import QtPositioning 5.3
import QtLocation 5.3
import QtQuick 2.0
import QtQuick 2.15

Item {
Plugin {
id: mapPlugin
required.mapping: Plugin.AnyMappingFeatures
required: Plugin.AnyMappingFeatures
preferred: [ "osm" ]
}

Expand All @@ -34,7 +34,9 @@ Item {
opacity: 0.5
Connections {
target: _controller
onOverrideCoordinateChanged: sourceTrace.addCoordinate(_controller.sourceCoordinate)
function onOverrideCoordinateChanged() {
sourceTrace.addCoordinate(_controller.sourceCoordinate);
}
}
}

Expand All @@ -45,7 +47,9 @@ Item {
opacity: 0.5
Connections {
target: _controller
onOverrideCoordinateChanged: overrideTrace.addCoordinate(_controller.overrideCoordinate)
function onOverrideCoordinateChanged() {
overrideTrace.addCoordinate(_controller.overrideCoordinate);
}
}
}

Expand Down Expand Up @@ -152,6 +156,10 @@ Item {

Connections {
target: _controller
onCenterOnPosition: map.center = _controller.overrideEnabled ? _controller.overrideCoordinate : _controller.sourceCoordinate
function onCenterOnPosition() {
map.center = _controller.overrideEnabled
? _controller.overrideCoordinate
: _controller.sourceCoordinate;
}
}
}

0 comments on commit 3727fcc

Please sign in to comment.