Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved dashboard component extensibility. #60

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jobosk
Copy link

@jobosk jobosk commented Mar 8, 2023

Modified dashboard component in order to allow tags to be passed as a parameter even if there is no entity context.
In response to: #59

# Conflicts:
#	src/components/DashboardsCard/DashboardsCard.tsx
# Conflicts:
#	src/components/DashboardsCard/DashboardsCard.tsx
@jobosk
Copy link
Author

jobosk commented Apr 3, 2023

Hi @K-Phoen , I updated this PR with your latest modifications regarding queries by tag to grafana.
I would appreciate if you could have a look and consider aproving.
In my team this change is really useful in order to use your component within techdocs, where there is no entity context available (but we can still get the entity tags).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants