Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in tensoralloc for Bumper allocator #188

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Fix typo in tensoralloc for Bumper allocator #188

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bb8ac3
Fix typo(?) in `tensoralloc` for Bumper allocator
Oct 2, 2024
efe4659
Change fix to reflect original intention
leburgel Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/TensorOperationsBumperExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ function TensorOperations.tensoralloc(::Type{A}, structure, ::Val{istemp},
buf::Union{SlabBuffer,AllocBuffer}) where {A<:AbstractArray,
istemp}
# TODO: remove the `ndims` check if this is fixed in Bumper / StrideArraysCore
if istemp & ndims(A) > 0
if istemp & (ndims(A) > 0)
leburgel marked this conversation as resolved.
Show resolved Hide resolved
return Bumper.alloc!(buf, eltype(A), structure...)
else
return TensorOperations.tensoralloc(A, structure, Val(istemp))
Expand Down
Loading