Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix premature freeing of temporary tensors during reverse mode AD. #170

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Fix premature freeing of temporary tensors during reverse mode AD. #170

merged 2 commits into from
Apr 21, 2024

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Apr 20, 2024

No description provided.

@lkdvos lkdvos linked an issue Apr 20, 2024 that may be closed by this pull request
Freed reference problem when combining cuTENSOR and Zygote #169
Closed
@Jutho
Copy link
Owner

Jutho commented Apr 20, 2024

That's a subtle bug indeed; nice catch.

@lkdvos
Copy link
Collaborator Author

lkdvos commented Apr 21, 2024

Should be ready to merge now

@Jutho Jutho merged commit 80c8b67 into master Apr 21, 2024
15 checks passed
@lkdvos lkdvos deleted the ad-free branch April 22, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jutho Jutho Jutho left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Freed reference problem when combining cuTENSOR and Zygote
2 participants
@lkdvos @Jutho